[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0802201039520.19893@vixen.sonytel.be>
Date: Wed, 20 Feb 2008 10:40:59 +0100 (CET)
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
cc: linux-ide@...r.kernel.org,
Linux Kernel Development <linux-kernel@...r.kernel.org>,
Michael Schmitz <schmitz@...ian.org>
Subject: Re: [PATCH] falconide: fix resources reservation
On Wed, 20 Feb 2008, Bartlomiej Zolnierkiewicz wrote:
> * Tell IDE layer to not manage resources by setting
> hwif->mmio flag and request resources in falconide_init().
>
> * Use request_mem_region() for resources reservation.
>
> * Use driver name for resources reservation.
>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Michael Schmitz <schmitz@...ian.org>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> ---
> drivers/ide/legacy/falconide.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> Index: b/drivers/ide/legacy/falconide.c
> ===================================================================
> --- a/drivers/ide/legacy/falconide.c
> +++ b/drivers/ide/legacy/falconide.c
> @@ -22,6 +22,7 @@
> #include <asm/atariints.h>
> #include <asm/atari_stdma.h>
>
> +#define DRV_NAME "falconide"
>
> /*
> * Base of the IDE interface
> @@ -74,6 +75,11 @@ static int __init falconide_init(void)
>
> printk(KERN_INFO "ide: Falcon IDE controller\n");
>
> + if (!request_mem_region(ATA_HD_BASE, 0x40, DRV_NAME)) {
> + printk(KERN_ERR "%s: resources busy\n");
^^
Woops, missing parameter?
pr_error()?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists