linux-kernel - Re: mm/slub.c: inconsequent NULL checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f8gTuy3.1203515564.2078250.penberg@cs.helsinki.fi>
Date:	Wed, 20 Feb 2008 15:52:44 +0200 (EET)
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	bunk@...nel.org, clameter@....com, penberg@...helsinki.fi,
	mpm@...enic.com
CC:	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: mm/slub.c: inconsequent NULL checking


Hi Adrian,

On 2/20/2008, "Adrian Bunk" <bunk@...nel.org> wrote:
> The Coverity checker spotted the following inconsequent NULL checking
> introduced by commit 8ff12cfc009a2a38d87fa7058226fe197bb2696f:
> 
> <--  snip  -->
> 
> ...
> static inline int is_end(void *addr)
> {
>         return (unsigned long)addr & PAGE_MAPPING_ANON;
> }
> ...
> static void deactivate_slab(struct kmem_cache *s, struct kmem_cache_cpu *c)
> {
> ...
>         if (c->freelist)    <----------------------------------------
>                 stat(c, DEACTIVATE_REMOTE_FREES);

I spotted this too. c->freelist should never be NULL so why not send a
patch to Christoph?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/