linux-kernel - Re: [PATCH] PM: Remove unbalanced mutex_unlock() from dpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0802201112010.4828-100000@iolanthe.rowland.org>
Date:	Wed, 20 Feb 2008 11:13:39 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	Greg KH <greg@...ah.com>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Len Brown <lenb@...nel.org>,
	Linux-pm mailing list <linux-pm@...ts.osdl.org>,
	LKML <linux-kernel@...r.kernel.org>, Pavel Machek <pavel@....cz>
Subject: Re: [PATCH] PM: Remove unbalanced mutex_unlock() from dpm_resume()

On Wed, 20 Feb 2008, Rafael J. Wysocki wrote:

> Hi Greg,
> 
> Please consider taking the following fix for 2.6.25.

Don't just consider it!  :-)  It's a real bug fix.

> Thanks,
> Rafael
> 
> ---
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> Remove an unnecessary unlocking of dpm_list_mtx in the error path
> in drivers/base/power/main.c:dpm_suspend() .
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
>  drivers/base/power/main.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux-2.6/drivers/base/power/main.c
> ===================================================================
> --- linux-2.6.orig/drivers/base/power/main.c
> +++ linux-2.6/drivers/base/power/main.c
> @@ -479,7 +479,6 @@ static int dpm_suspend(pm_message_t stat
>  			mutex_lock(&dpm_list_mtx);
>  			if (list_empty(&dev->power.entry))
>  				list_add(&dev->power.entry, &dpm_locked);
> -			mutex_unlock(&dpm_list_mtx);
>  			break;
>  		}
>  		mutex_lock(&dpm_list_mtx);

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/