[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <47BC5ACB.6070203@pobox.com>
Date: Wed, 20 Feb 2008 11:52:27 -0500
From: Jeff Garzik <jgarzik@...ox.com>
To: Adrian Bunk <bunk@...nel.org>
CC: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] net/phy/mdio_bus.c: fix a check-after-use
Adrian Bunk wrote:
> This patch fixes a check-after-use spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
>
> ---
> 6beeb3ac577d74d72b2f91bd654eecb904c3c17e diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
> index 6e9f619..963630c 100644
> --- a/drivers/net/phy/mdio_bus.c
> +++ b/drivers/net/phy/mdio_bus.c
> @@ -49,13 +49,13 @@ int mdiobus_register(struct mii_bus *bus)
> int i;
> int err = 0;
>
> - mutex_init(&bus->mdio_lock);
> -
> if (NULL == bus || NULL == bus->name ||
> NULL == bus->read ||
> NULL == bus->write)
> return -EINVAL;
>
> + mutex_init(&bus->mdio_lock);
> +
applied
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists