linux-kernel - Re: [PATCH 11/11v2] ata: fix sparse warnings in pata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 20 Feb 2008 12:09:37 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>, Tejun Heo <htejun@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-ide <linux-ide@...r.kernel.org>
Subject: Re: [PATCH 11/11v2] ata: fix sparse warnings in pata_legacy.c

Harvey Harrison wrote:
> Use ld_qdi and ld_winbond to avoid shadowing static int
> variables qdi and winbond.  The ld_ prefix refers to
> legacy_data.
> 
> drivers/ata/pata_legacy.c:777:21: warning: symbol 'qdi' shadows an earlier one
> drivers/ata/pata_legacy.c:128:12: originally declared here
> drivers/ata/pata_legacy.c:811:21: warning: symbol 'qdi' shadows an earlier one
> drivers/ata/pata_legacy.c:128:12: originally declared here
> drivers/ata/pata_legacy.c:848:21: warning: symbol 'qdi' shadows an earlier one
> drivers/ata/pata_legacy.c:128:12: originally declared here
> drivers/ata/pata_legacy.c:882:21: warning: symbol 'qdi' shadows an earlier one
> drivers/ata/pata_legacy.c:128:12: originally declared here
> drivers/ata/pata_legacy.c:1040:21: warning: symbol 'winbond' shadows an earlier one
> drivers/ata/pata_legacy.c:129:12: originally declared here
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
> Alan Cox's suggestion of using a ld_ prefix incorporated.

applied

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/