[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <47BCA229.1090406@oracle.com>
Date: Wed, 20 Feb 2008 13:56:57 -0800
From: Randy Dunlap <randy.dunlap@...cle.com>
To: Marcel Holtmann <marcel@...tmann.org>
CC: lkml <linux-kernel@...r.kernel.org>, gregkh <greg@...ah.com>,
akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] firmware: fix a few build errors
Marcel Holtmann wrote:
> Hi Randy,
>
>> Fix one typo (comma to semi-colon).
>> Fix sysfs externs (just use sysfs.h for prototypes).
>>
>> Documentation/firmware_class/firmware_sample_firmware_class.c:37:
>> error: conflicting types for 'sysfs_remove_bin_file'
>> include/linux/sysfs.h:100: error: previous declaration of
>> 'sysfs_remove_bin_file' was here
>>
>> Still has a build error:
>> ERROR: "firmware_class"
>> [samples/firmware_class/firmware_sample_firmware_class.ko]
>> undefined!
>
> while you are at it, can you also fix the broken coding style in it?
Greg will do that while he is fixing the <firmware_class> data build error. :)
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists