linux-kernel - Re: [2.6 patch] scsi/qla4xxx/ql4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200802211251.34437.eike-kernel@sf-tec.de>
Date:	Thu, 21 Feb 2008 12:51:23 +0100
From:	Rolf Eike Beer <eike-kernel@...tec.de>
To:	"David Somayajulu" <david.somayajulu@...gic.com>
Cc:	"Andrew Vasquez" <andrew.vasquez@...gic.com>,
	"James Bottomley" <James.Bottomley@...senpartnership.com>,
	"Adrian Bunk" <bunk@...nel.org>, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [2.6 patch] scsi/qla4xxx/ql4_isr.c: remove dead code

> The correct patch needs to be
>
> Signed-off-by: David C Somayajulu <david.somayajulu@...gic.com>
>
> ---
>
> diff --git a/drivers/scsi/qla4xxx/ql4_isr.c
> b/drivers/scsi/qla4xxx/ql4_isr.c
> index 0f029d0..fc84db4 100644
> --- a/drivers/scsi/qla4xxx/ql4_isr.c
> +++ b/drivers/scsi/qla4xxx/ql4_isr.c
> @@ -100,8 +100,7 @@ static void qla4xxx_status_entry(struct
>
>  		if (sts_entry->iscsiFlags &ISCSI_FLAG_RESIDUAL_UNDER) {
>  			scsi_set_resid(cmd, residual);
> -			if (!scsi_status && ((scsi_bufflen(cmd) -
> residual) <
> -				cmd->underflow)) {
> +			if ((scsi_bufflen(cmd) - residual) <
> cmd->underflow) {

The patch is line-wrapped and can' be applied.

Greetings,

Eike

Download attachment "signature.asc " of type "application/pgp-signature" (195 bytes)