linux-kernel - Re: [PATCH] X86: remove WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080221132732.GB20053@amd.com>
Date:	Thu, 21 Feb 2008 14:27:32 +0100
From:	"Joerg Roedel" <joerg.roedel@....com>
To:	"Ingo Molnar" <mingo@...e.hu>
cc:	tglx@...utronix.de, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] X86: remove WARN_ON if MTRRs are all blank

On Thu, Feb 21, 2008 at 02:03:32PM +0100, Ingo Molnar wrote:
> 
> * Joerg Roedel <joerg.roedel@....com> wrote:
> 
> > > >  	if (!highest_pfn) {
> > > >  		printk(KERN_WARNING "WARNING: strange, CPU MTRRs all blank?\n");
> > > > -		WARN_ON(1);
> > > >  		return 0;
> > > >  	}
> > > 
> > > instead of obscuring a possibly useful warning, please instead 
> > > detect that it's a KVM guest and skip both the warning and the 
> > > backtrace in that case.
> > 
> > How usefull is the backtrace in that place? I agree that the printk 
> > warning may be usefull, but I don't see why the backtrace from the 
> > WARN_ON is necessary.
> 
> it allows us to collect such things on kerneloops.org for example.

Makes sense. I will send an updated patch.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/