linux-kernel - Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <je4pc2s1r7.fsf@sykes.suse.de>
Date:	Thu, 21 Feb 2008 17:38:52 +0100
From:	Andreas Schwab <schwab@...e.de>
To:	David Howells <dhowells@...hat.com>
Cc:	torvalds@...l.org, akpm@...ux-foundation.org,
	zippel@...ux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Make the kernel NTP code hand 64-bit *unsigned* values to do_div()

David Howells <dhowells@...hat.com> writes:

>  			if (time_offset < 0) {
> -			    temp64 = -temp64;
> -			    do_div(temp64, mtemp);
> +			    utemp64 = -temp64;
> +			    do_div(utemp64, mtemp);
>  			    freq_adj -= temp64;

do_div previously modified temp64 by side effect, now it no longer does
that.

>  			} else {
> -			    do_div(temp64, mtemp);
> +			    utemp64 = temp64;
> +			    do_div(utemp64, mtemp);
>  			    freq_adj += temp64;

Same.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@...e.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/