linux-kernel - Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric constant in boot code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080221195628.GB6772@cvg>
Date:	Thu, 21 Feb 2008 22:56:28 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: cleanup - use PAGE_SIZE instead of numeric
	constant in boot code

[H. Peter Anvin - Thu, Feb 21, 2008 at 11:52:56AM -0800]
> Cyrill Gorcunov wrote:
>> This patch replaces 4096 numeric constant with PAGE_SIZE macro.
>> Signed-off-by: Cyrill Gorcunov <gorcunov@...il.com>
>> ---
>> Text segments of old and new files *are* the same so
>> it wouldn't break current kernel.
>
> NAK.
>
> This is NOT PAGE_SIZE (even though the two values are coincidentally the 
> same, for historical reasons.)
>
> 	-hpa
>

hmm, why the comment on boot_param structure definition calls
it "zeropage"? Anyway really thanks for review and catched this.

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/