linux-kernel - Re: [PATCH] mac80211: check endianness/types in sparse runs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1203624563.26341.15.camel@johannes.berg>
Date:	Thu, 21 Feb 2008 21:09:23 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	John Linville <linville@...driver.com>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	Stefano Brivio <stefano.brivio@...imi.it>,
	Al Viro <viro@...iv.linux.org.uk>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mac80211: check endianness/types in sparse runs


> > In any case, I would love to have __CHECK_ENDIAN__ enabled by default at
> > least on the wireless code (just caught another bug with it...)
> 
> I should then add support for something like:
> 
> checkflags-y := -D__CHECK_ENDIAN__
> 
> to match the style of the rest.
> 
> I do not like all the buried in assumption about the
> global variables.

That might be good. I retract my patch for now then.

> But I would prefer that someone would spend a few days looking into the
> warnings generated with sparse.

I did spend a bit of time running it on all the tree, but wireless,
where I do most work, is clean. I have some code in sound/ that
generates warnings and some drivers/macintosh/ code I worked on too, but
right now I don't want to pick up too many changes all over the tree
into my patches tree.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)