linux-kernel - Re: [PATCH] viocons: BKL locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18364.63205.933131.746580@cargo.ozlabs.ibm.com>
Date:	Thu, 21 Feb 2008 14:58:29 +1100
From:	Paul Mackerras <paulus@...ba.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, sfr@...b.auug.org.au
Subject: Re: [PATCH] viocons: BKL locking

Alan Cox writes:

> For some weird reason I can't ascertain (translation "I think its
> broken") the viocons driver calls directly into the n_tty ldisc code even
> if another ldisc is in use. It'll probably break if you do that but I'm
> just fixing the locking and adding a comment that its horked.

Looks to me like it (viotty_ioctl) should return -ENOIOCTLCMD instead
of calling n_tty_ioctl -- do you agree?

Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/