linux-kernel - Re: [PATCH 2/2] make work have a static address in do_boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080222094628.GB6269@elte.hu>
Date:	Fri, 22 Feb 2008 10:46:28 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Glauber Costa <glommer@...il.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Glauber Costa <gcosta@...hat.com>,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	arjan@...radead.org
Subject: Re: [PATCH 2/2] make work have a static address in do_boot_cpu()


* Glauber Costa <glommer@...il.com> wrote:

> >  Looks way overkill. Doesn't something like:

> >  >       struct create_idle create_idle = {
> >  > -             .work = __WORK_INITIALIZER(create_idle.work, do_fork_idle),
> >  >               .cpu = cpu,
> >  >               .done = COMPLETION_INITIALIZER_ONSTACK(create_idle.done),
> >  >       };
> >  > +     INIT_WORK(&create_idle.work, do_fork_idle);
> >
> >  work?
> 
> Indeed.
> 
> I missed the static lock_class_key definition inside INIT_WORK macro. 
> It does the job neatly.

could you resend the updated patch?

	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/