linux-kernel - Re: [PATCH] X86: don't print a warning when MTRR are blank and running in KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080222111518.GA6504@amd.com>
Date:	Fri, 22 Feb 2008 12:15:18 +0100
From:	"Joerg Roedel" <joerg.roedel@....com>
To:	"Ingo Molnar" <mingo@...e.hu>
cc:	"H. Peter Anvin" <hpa@...or.com>, tglx@...utronix.de,
	mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] X86: don't print a warning when MTRR are blank and
 running in KVM

On Fri, Feb 22, 2008 at 11:00:44AM +0100, Ingo Molnar wrote:
> 
> * H. Peter Anvin <hpa@...or.com> wrote:
> 
> > Ingo Molnar wrote:
> >> * H. Peter Anvin <hpa@...or.com> wrote:
> >>
> >>>> I'm not sure how we could detect pure Qemu instances - perhaps it should 
> >>>> define some special MSR or something?
> >>> Perhaps they should fix the Qemu BIOS to actually simulate working MSRs; 
> >>> if nothing else, they should set up the default MTRR to be cachable.
> >>
> >> btw., should KVM do the same?
> >
> > Yes.  Especially since they share a BIOS.
> 
> ok. Then i guess we should just leave the warning and the backtrace in 
> place until they get a fix done?

No. I don't agree. The MTRRs are set up by the BIOS because it knows the
hardware best (I know this is only true in theory). The OS should
basically trust the BIOS MTRR settings. If the OS can't trust the BIOS,
like on real hardware, the check and the warning is necessary. If the OS
can trust the BIOS, like running in a KVM or QEMU virtual machine, it
should just ignore the case where all MTRRs are blank.

Joerg

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/