linux-kernel - Re: [ofa-general] Re: Merging of completely unreviewed drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2e108260802220429l5857c3edj351246ee31dd2a3e@mail.gmail.com>
Date:	Fri, 22 Feb 2008 13:29:31 +0100
From:	"Bart Van Assche" <bart.vanassche@...il.com>
To:	"David Newall" <davidn@...idnewall.com>
Cc:	"Krzysztof Halasa" <khc@...waw.pl>,
	"Adrian Bunk" <bunk@...nel.org>,
	"Greg Kroah-Hartman" <greg@...ah.com>,
	"Roland Dreier" <rdreier@...co.com>, linux-kernel@...r.kernel.org,
	general@...ts.openfabrics.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Glenn Streiff" <gstreiff@...effect.com>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Faisal Latif" <flatif@...effect.com>
Subject: Re: [ofa-general] Re: Merging of completely unreviewed drivers

On Fri, Feb 22, 2008 at 2:46 AM, David Newall <davidn@...idnewall.com> wrote:
> Krzysztof Halasa wrote:
>  > Perhaps we should increase line length limit, 132 should be fine.
>  > Especially useful with long printk() lines and long arithmetic
>  > expressions.
>
>  Yes; or even longer.  80 characters might have made sense on a screen
>  when the alternative was 80 characters on a punched card, but on a
>  modern computer it's very restrictive.  That's especially true with the
>  deep indents that you quickly get in C.  Even short lines often need to
>  be split when you put a few tabs in front of them, and that makes
>  comprehension that bit harder, not to mention looks ugly.

There is a reason to limit line length: scientific research has shown
that readability of regular texts is optimal for a line length between
55 and 65 characters. My experience is that the readability of source
code decreases when the lines are very long (more than 160
characters).

Bart Van Assche.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/