| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <12036890142414-git-send-email-giometti@linux.it>
Date: Fri, 22 Feb 2008 15:03:31 +0100
From: Rodolfo Giometti <giometti@...ux.it>
To: linux-kernel@...r.kernel.org
Cc: Andrew Morton <akpm@...ux-foundation.org>,
David Woodhouse <dwmw2@...radead.org>,
Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
Greg KH <greg@...ah.com>,
Randy Dunlap <randy.dunlap@...cle.com>,
Rodolfo Giometti <giometti@...ux.it>
Subject: [PATCH] PPS: serial clients support.
Adds support for the PPS sources connected with the CD (Carrier
Detect) pin of a serial port.
Signed-off-by: Rodolfo Giometti <giometti@...ux.it>
---
drivers/pps/clients/Kconfig | 10 ++++++
drivers/serial/8250.c | 2 +
drivers/serial/serial_core.c | 71 +++++++++++++++++++++++++++++++++++++++++-
include/linux/serial_core.h | 30 ++++++++++++++---
4 files changed, 106 insertions(+), 7 deletions(-)
diff --git a/drivers/pps/clients/Kconfig b/drivers/pps/clients/Kconfig
index 60b83be..517c338 100644
--- a/drivers/pps/clients/Kconfig
+++ b/drivers/pps/clients/Kconfig
@@ -15,4 +15,14 @@ config PPS_CLIENT_KTIMER
This driver can also be built as a module. If so, the module
will be called ktimer.ko.
+comment "UART serial support (forced off)"
+ depends on ! (SERIAL_CORE != n && !(PPS = m && SERIAL_CORE = y))
+
+config PPS_CLIENT_UART
+ bool "UART serial support"
+ depends on SERIAL_CORE != n && !(PPS = m && SERIAL_CORE = y)
+ help
+ If you say yes here you get support for a PPS source connected
+ with the CD (Carrier Detect) pin of your serial port.
+
endif
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 77f7a7f..880cbeb 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -2119,6 +2119,8 @@ serial8250_set_termios(struct uart_port *port, struct ktermios *termios,
up->ier |= UART_IER_MSI;
if (up->capabilities & UART_CAP_UUE)
up->ier |= UART_IER_UUE | UART_IER_RTOIE;
+ if (up->port.flags & UPF_HARDPPS_CD)
+ up->ier |= UART_IER_MSI; /* enable interrupts */
serial_out(up, UART_IER, up->ier);
diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c
index 0f5a179..e35fbef 100644
--- a/drivers/serial/serial_core.c
+++ b/drivers/serial/serial_core.c
@@ -33,6 +33,7 @@
#include <linux/serial.h> /* for serial_state and serial_icounter_struct */
#include <linux/delay.h>
#include <linux/mutex.h>
+#include <linux/pps.h>
#include <asm/irq.h>
#include <asm/uaccess.h>
@@ -635,6 +636,54 @@ static int uart_get_info(struct uart_state *state,
return 0;
}
+#ifdef CONFIG_PPS_CLIENT_UART
+
+static int
+uart_register_pps_port(struct uart_state *state, struct uart_port *port)
+{
+ struct tty_driver *drv = port->info->tty->driver;
+ int ret;
+
+ state->pps_info.owner = THIS_MODULE;
+ state->pps_info.dev = port->dev;
+ snprintf(state->pps_info.name, PPS_MAX_NAME_LEN, "%s%d",
+ drv->driver_name, port->line);
+ snprintf(state->pps_info.path, PPS_MAX_NAME_LEN, "/dev/%s%d",
+ drv->name, port->line);
+
+ state->pps_info.mode = PPS_CAPTUREBOTH | \
+ PPS_OFFSETASSERT | PPS_OFFSETCLEAR | \
+ PPS_CANWAIT | PPS_TSFMT_TSPEC;
+
+ ret = pps_register_source(&state->pps_info, PPS_CAPTUREBOTH | \
+ PPS_OFFSETASSERT | PPS_OFFSETCLEAR);
+ if (ret < 0) {
+ dev_err(port->dev, "cannot register PPS source \"%s\"\n",
+ state->pps_info.path);
+ return ret;
+ }
+ port->pps_source = ret;
+ dev_dbg(port->dev, "PPS source #%d \"%s\" added\n",
+ port->pps_source, state->pps_info.path);
+
+ return 0;
+}
+
+static void
+uart_unregister_pps_port(struct uart_state *state, struct uart_port *port)
+{
+ pps_unregister_source(port->pps_source);
+ dev_dbg(port->dev, "PPS source #%d \"%s\" removed\n",
+ port->pps_source, state->pps_info.path);
+}
+
+#else
+
+#define uart_register_pps_port(state, port) do { } while (0)
+#define uart_unregister_pps_port(state, port) do { } while (0)
+
+#endif /* CONFIG_PPS_CLIENT_UART */
+
static int uart_set_info(struct uart_state *state,
struct serial_struct __user *newinfo)
{
@@ -810,11 +859,19 @@ static int uart_set_info(struct uart_state *state,
(port->flags & UPF_LOW_LATENCY) ? 1 : 0;
check_and_exit:
+ /* PPS support enabled/disabled? */
+ if ((old_flags & UPF_HARDPPS_CD) != (new_flags & UPF_HARDPPS_CD)) {
+ if (new_flags & UPF_HARDPPS_CD)
+ uart_register_pps_port(state, port);
+ else
+ uart_unregister_pps_port(state, port);
+ }
+
retval = 0;
if (port->type == PORT_UNKNOWN)
goto exit;
if (state->info->flags & UIF_INITIALIZED) {
- if (((old_flags ^ port->flags) & UPF_SPD_MASK) ||
+ if (((old_flags ^ port->flags) & (UPF_SPD_MASK|UPF_HARDPPS_CD)) ||
old_custom_divisor != port->custom_divisor) {
/*
* If they're setting up a custom divisor or speed,
@@ -2148,6 +2205,12 @@ uart_configure_port(struct uart_driver *drv, struct uart_state *state,
port->ops->config_port(port, flags);
}
+ /*
+ * Add the PPS support for the current port.
+ */
+ if (port->flags & UPF_HARDPPS_CD)
+ uart_register_pps_port(state, port);
+
if (port->type != PORT_UNKNOWN) {
unsigned long flags;
@@ -2405,6 +2468,12 @@ int uart_remove_one_port(struct uart_driver *drv, struct uart_port *port)
mutex_unlock(&state->mutex);
/*
+ * Remove PPS support from the current port.
+ */
+ if (port->flags & UPF_HARDPPS_CD)
+ uart_unregister_pps_port(state, port);
+
+ /*
* Remove the devices from the tty layer
*/
tty_unregister_device(drv->tty_driver, port->line);
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index 289942f..0f8fbd4 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -166,6 +166,7 @@
#include <linux/tty.h>
#include <linux/mutex.h>
#include <linux/sysrq.h>
+#include <linux/pps.h>
struct uart_port;
struct uart_info;
@@ -245,6 +246,9 @@ struct uart_port {
unsigned char regshift; /* reg offset shift */
unsigned char iotype; /* io access style */
unsigned char unused1;
+#ifdef CONFIG_PPS_CLIENT_UART
+ int pps_source; /* PPS source ID */
+#endif
#define UPIO_PORT (0)
#define UPIO_HUB6 (1)
@@ -289,7 +293,8 @@ struct uart_port {
#define UPF_IOREMAP ((__force upf_t) (1 << 31))
#define UPF_CHANGE_MASK ((__force upf_t) (0x17fff))
-#define UPF_USR_MASK ((__force upf_t) (UPF_SPD_MASK|UPF_LOW_LATENCY))
+#define UPF_USR_MASK ((__force upf_t) (UPF_SPD_MASK|UPF_LOW_LATENCY\
+ |UPF_HARDPPS_CD))
unsigned int mctrl; /* current modem ctrl settings */
unsigned int timeout; /* character-based timeout */
@@ -322,6 +327,10 @@ struct uart_state {
struct uart_info *info;
struct uart_port *port;
+#ifdef CONFIG_PPS_CLIENT_UART
+ struct pps_source_info pps_info;
+#endif
+
struct mutex mutex;
};
@@ -486,13 +495,22 @@ uart_handle_dcd_change(struct uart_port *port, unsigned int status)
{
struct uart_info *info = port->info;
- port->icount.dcd++;
-
-#ifdef CONFIG_HARD_PPS
- if ((port->flags & UPF_HARDPPS_CD) && status)
- hardpps();
+#ifdef CONFIG_PPS_CLIENT_UART
+ if (port->flags & UPF_HARDPPS_CD) {
+ if (status) {
+ pps_event(port->pps_source, PPS_CAPTUREASSERT, port);
+ dev_dbg(port->dev, "PPS assert at %lu on source #%d\n",
+ jiffies, port->pps_source);
+ } else {
+ pps_event(port->pps_source, PPS_CAPTURECLEAR, port);
+ dev_dbg(port->dev, "PPS clear at %lu on source #%d\n",
+ jiffies, port->pps_source);
+ }
+ }
#endif
+ port->icount.dcd++;
+
if (info->flags & UIF_CHECK_CD) {
if (status)
wake_up_interruptible(&info->open_wait);
--
1.5.2.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists