linux-kernel - Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0802220827520.19896@woody.linux-foundation.org>
Date:	Fri, 22 Feb 2008 08:43:22 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Andi Kleen <andi@...stfloor.org>
cc:	Jeremy Fitzhardinge <jeremy@...p.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

On Fri, 22 Feb 2008, Andi Kleen wrote:
>
> Linus Torvalds <torvalds@...ux-foundation.org> writes:
> >
> > (*) I keed, I keed. Of *course* I'll have to fix things like this in the 
> > future too. But hopefully not quite as often.
> 
> The pragmatic solution would be to just fix the scripts to accept From
> everywhere @)

I worry about that. We've actually had to tighten up the scripts over time 
to not assign meaning to things, because people put various things in the 
free-form descriptions, and it's really bad to corrupt the description.

This isn't a problem with things like "Signed-off-by:" etc tags, because 
they have no automated meaning and don't really change the commit itself, 
but the "From:"/"Date:"/"Subject:" markers at the head of the message 
really do have real meaning, and get removed from the commit message and 
instead get put into the SCM headers.

So I'd rather have the rules be very strict and not cause any surprises, 
than have loose rules and then occasionally an email has a "From:" in the 
middle and my scripts get all confused.

It's not a *huge* problem, and my gut feel is that it's getting rarer as 
people learn. Rigth now we have about 86,000 commits in the mainline git 
history, and 807 (less than 1%) of those have a 'From:' in the message. 
And in many cases, that "From:" was at the head, so there are simply 
people who do not *use* the standard scripts and making the scripts accept 
it everywhere wouldn't have helped anyway!

And in the great majority of cases - at least the ones I looked at - 
authorship actually got attributed correctly. And in some of the cases, 
the "From:" really *was* part of the message, and removing it would have 
been wrong. See for example 22e78fafbdf84883f70eb4944cf658fc23c4a1f4 where 
the From: was about an email exchange (it gave the rigth author anyway, 
but without that line the commit message would have made less sense).

There are a few other cases with "From:" in the middle, where the From: 
doesn't mean authorship (but attributes fixes to the patch, for example). 
It's admittedly fairly rare, but it shows that it happens (I found 
something like four occurrences of that before I got too bored).

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/