linux-kernel - Re: [2.6 patch] mm/slub.c: remove unneeded NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47BF2C73.4030308@cs.helsinki.fi>
Date:	Fri, 22 Feb 2008 22:11:31 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Adrian Bunk <bunk@...nel.org>
CC:	clameter@....com, mpm@...enic.com,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [2.6 patch] mm/slub.c: remove unneeded NULL check

Adrian Bunk wrote:
> There's no reason for checking c->freelist for being NULL here (and we'd 
> anyway Oops below if it was).
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> ---
> dae2a3c60f258f3ad2522b85d79b735a89d702f0 diff --git a/mm/slub.c b/mm/slub.c
> index 74c65af..072e0a6 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1404,8 +1404,7 @@ static void deactivate_slab(struct kmem_cache *s, struct kmem_cache_cpu *c)
>  	struct page *page = c->page;
>  	int tail = 1;
>  
> -	if (c->freelist)
> -		stat(c, DEACTIVATE_REMOTE_FREES);
> +	stat(c, DEACTIVATE_REMOTE_FREES);
>  	/*
>  	 * Merge cpu freelist into freelist. Typically we get here
>  	 * because both freelists are empty. So this is unlikely

Christoph, please apply.

Reviewed-by: Pekka Enberg <penberg@...helsinki.fi>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/