linux-kernel - Re: [2.6 patch] kernel/ns_cgroup.c should #include <linux/nsproxy.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080223000206.GA14216@sergelap.austin.ibm.com>
Date:	Fri, 22 Feb 2008 18:02:06 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	"Serge E. Hallyn" <serue@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] kernel/ns_cgroup.c should #include
	<linux/nsproxy.h>

Quoting Adrian Bunk (bunk@...nel.org):
> Every file should include the headers containing the externs its global 
> functions (in this case for ns_cgroup_clone()).
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>

Seems fine...  and a good way to ensure that the prototype and
definition match.

Acked-by: Serge Hallyn <serue@...ibm.com>

thanks,
-serge

> 
> ---
> d3446a02068091d59425c51bde1daea777398e44 diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c
> index aead4d6..659f321 100644
> --- a/kernel/ns_cgroup.c
> +++ b/kernel/ns_cgroup.c
> @@ -7,6 +7,7 @@
>  #include <linux/module.h>
>  #include <linux/cgroup.h>
>  #include <linux/fs.h>
> +#include <linux/nsproxy.h>
> 
>  struct ns_cgroup {
>  	struct cgroup_subsys_state css;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/