linux-kernel - Re: [PATCH 00/16] (Resend) Use get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080223092710.GD2262@martell.zuzino.mipt.ru>
Date:	Sat, 23 Feb 2008 12:27:10 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	WANG Cong <xiyou.wangcong@...il.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/16] (Resend) Use get_personality()

On Sat, Feb 23, 2008 at 04:59:44PM +0800, WANG Cong wrote:
> From: Alexey Dobriyan <adobriyan@...il.com>
> Subject: Re: [PATCH 00/16] (Resend) Use get_personality()

> > On Sat, Feb 23, 2008 at 04:14:03PM +0800, WANG Cong wrote:
> > > This patchset makes the macro get_personality function alike
> > > and teaches code to use get_personality() instead of explicit
> > > reference.
> > > 
> > > [I am sorry if you've received multiple copied of this, since
> > >  my git-send-email doesn't work well. ]
> > 
> > Yes, but why? "current->personality" is way more understandable than
> > your macro because task subject to dereference is very visible.
> 
> Use get_personality() can hide the task_struct internals a bit.

->personality is going to become something less trivial?
Sorry, but you sound like C++ people writing tons of pointless get/set
wrappers. And your get_personality() is worse -- C++ would write it as

	current->personality()

and again, even here, it's immediately visible that current task is
involved, not some other task.

> And I don't think using the macro to access it is less understandable.
> Since 'current' won't be NULL, whether the dereference is visible is
> not important.

It's not about NULL vs non-NULL at all.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/