linux-kernel - Re: [PATCH 20/20] x86: Coding Style fixes to arch/x86/xen/multicalls.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 23 Feb 2008 11:01:40 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Joe Perches <joe@...ches.com>
Cc:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>, hpa <hpa@...or.com>,
	tglx <tglx@...utronix.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 20/20] x86: Coding Style fixes to
	arch/x86/xen/multicalls.c


* Joe Perches <joe@...ches.com> wrote:

> >  			printk(KERN_ERR "%d multicall(s) failed: cpu %d\n",
> >  			       ret, smp_processor_id());
> > -			for(i = 0; i < b->mcidx; i++) {
> > +			for (i = 0; i < b->mcidx; i++) {
> >  				printk("  call %2d/%d: op=%lu arg=[%lx] result=%ld\n",
> 
> The printk needs a KERN_ERR prefix

yes - but we prefer to isolate the "does not change the .o in any way" 
cleanups from cleanups that materially change kernel behavior. (such as 
printing something else)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/