linux-kernel - Re: [PATCH] x86: don't save unreliable stack trace entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 23 Feb 2008 11:25:39 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Vegard Nossum <vegard.nossum@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: don't save unreliable stack trace entries


* Arjan van de Ven <arjan@...radead.org> wrote:

> > b/arch/x86/kernel/stacktrace.c index 02f0f61..c28c342 100644
> > --- a/arch/x86/kernel/stacktrace.c
> > +++ b/arch/x86/kernel/stacktrace.c
> > @@ -25,6 +25,8 @@ static int save_stack_stack(void *data, char *name)
> >   static void save_stack_address(void *data, unsigned long addr, int
> > reliable) {
> >   	struct stack_trace *trace = data;
> > +	if (!reliable)
> > +		return;
> >   	if (trace->skip > 0) {
> >   		trace->skip--;
> >   		return;
> > @@ -37,6 +39,8 @@ static void
> >   save_stack_address_nosched(void *data, unsigned long addr, int
> > reliable) {
> >   	struct stack_trace *trace = (struct stack_trace *)data;
> > +	if (!reliable)
> > +		return;
> >   	if (in_sched_functions(addr))
> >   		return;
> >   	if (trace->skip > 0) {
> 
> 
> I was about to make a patch for this second chunk myself and submit 
> it, so for the second chunk a strong:
> Acked-by: Arjan van de Ven <arjan@...ux.intel.com>

how about the first chunk?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/