linux-kernel - Re: [PATCH] cgroup: fix sparse warning of shadow symbol in cgroup.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 23 Feb 2008 07:24:51 -0800
From:	"Paul Menage" <menage@...gle.com>
To:	"Paul Jackson" <pj@....com>
Cc:	akpm@...ux-foundation.org,
	"Harvey Harrison" <harvey.harrison@...il.com>,
	linux-kernel@...r.kernel.org, "Cliff Wickman" <cpw@....com>
Subject: Re: [PATCH] cgroup: fix sparse warning of shadow symbol in cgroup.c

On Sat, Feb 23, 2008 at 4:33 AM, Paul Jackson <pj@....com> wrote:
> From: Paul Jackson <pj@....com>
>
>  Fix a code warning: symbol 'p' shadows an earlier one
>
>  This is a reincarnation of Harvey Harrison's patch:
>         cpuset: sparse warnings in cpuset.c
>
>  Independently, Cliff Wickman moved the affected code,
>  from kernel/cpuset.c to kernel/cgroup.c, in his patch:
>         cpusets: update_cpumask revision
>
>  Signed-off-by: Paul Jackson <pj@....com>

Acked-by: Paul Menage <menage@...gle.com>

>  Cc: Harvey Harrison <harvey.harrison@...il.com>
>  Cc: Cliff Wickman <cpw@....com>
>
>  ---
>   kernel/cgroup.c |   10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
>  --- 2.6.25-rc2-mm1.orig/kernel/cgroup.c 2008-02-16 01:04:48.000000000 -0800
>  +++ 2.6.25-rc2-mm1/kernel/cgroup.c      2008-02-23 04:19:44.006614677 -0800
>  @@ -1897,14 +1897,14 @@ int cgroup_scan_tasks(struct cgroup_scan
>
>         if (heap->size) {
>                 for (i = 0; i < heap->size; i++) {
>  -                       struct task_struct *p = heap->ptrs[i];
>  +                       struct task_struct *q = heap->ptrs[i];
>                         if (i == 0) {
>  -                               latest_time = p->start_time;
>  -                               latest_task = p;
>  +                               latest_time = q->start_time;
>  +                               latest_task = q;
>                         }
>                         /* Process the task per the caller's callback */
>  -                       scan->process_task(p, scan);
>  -                       put_task_struct(p);
>  +                       scan->process_task(q, scan);
>  +                       put_task_struct(q);
>                 }
>                 /*
>                  * If we had to process any tasks at all, scan again
>
>  --
>                           I won't rest till it's the best ...
>                           Programmer, Linux Scalability
>                           Paul Jackson <pj@....com> 1.650.933.1373
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/