linux-kernel - Re: + kthread-add-a-missing-memory-barrier-to-kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080223182258.GA19946@tv-sign.ru>
Date:	Sat, 23 Feb 2008 21:22:58 +0300
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	dmitry.adamushko@...il.com, a.p.zijlstra@...llo.nl,
	apw@...dowen.org, mingo@...e.hu, nickpiggin@...oo.com.au,
	paulmck@...ux.vnet.ibm.com, rusty@...tcorp.com.au,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: + kthread-add-a-missing-memory-barrier-to-kthread_stop.patch added to -mm tree

On 02/23, Linus Torvalds wrote:
> 
> On Sat, 23 Feb 2008, Oleg Nesterov wrote:
> > 
> > In short: wake_up_process() doesn't imply mb(), this means that _in theory_
> > the commonly used code like
> > 
> > 	set_current_state(TASK_INTERRUPTIBLE);
> > 	if (CONDITION)
> > 		return;
> > 	schedule();
> > 
> > is racy wrt
> > 
> > 	CONDITION = 1;
> > 	wake_up_process(p);
> > 
> > I'll be happy to be wrong though, please correct me.
> 
> Well, you should be wrong on x86, because the spinlock at the head of 
> wake_up_process() (well, "try_to_wake_up()" to be exact) will be a full 
> memory barrier.
> 
> But yeah, in general spinlocks can have weaker semantics, and let 
> preceding writes percolate into the critical section and thus past the 
> point that actually sets task->state.

Yes. (I mean, this matches my understanding)

> And I do agree that we should *not* add a memory barrier in the caller 
> (that's just going to be really confusing for everybody, and make these 
> things much harder than they should be), and we should make sure that the 
> above sequence is always race-free.
> 
> I also think that a full memory barrier is overkill. We should be ok with 
> just adding a write barrier to the top of wake_up_process(), no? That way, 
> we know that the CONDITION will be seen on the other CPU before it sees 
> task->state change to TASK_RUNNING, so with the memory barrier int he 
> "set_current_state()", we know that the other side will see the new 
> condition _or_ it will see TASK_RUNNING when it hits schedule.

Yes, but still I suspect wmb() is not enough. Note that try_to_wake_up()
first checks (reads) the task->state,

	if (!(old_state & state))
		goto out;

without the full mb() it is (in theory) possible that try_to_wake_up()
first reads TASK_RUNNING and only then sets CONDITION. IOW, STORE and
LOAD could be re-ordered.

> (smp_wmb() also has the advantage of being a no-op on x86, where it's not 
> needed).

Can't we introduce smp_mb_before_spinlock() (or whatever) as iirc Steven
suggested some time ago?


A bit offtopic, but let's take another example, __queue_work()->insert_work().
With some trivial modification we can move set_wq_data() outside of cwq->lock.
But according to linux's memory model we still need wmb(), which is a bit
annoying. Perhaps we can also add smp_wmb_before_spinlock(). Not sure this
is not too ugly though.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/