linux-kernel - Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f19298770802231237m520e0158ldce3ae422796ae3b@mail.gmail.com>
Date:	Sat, 23 Feb 2008 23:37:13 +0300
From:	"Alexey Zaytsev" <alexey.zaytsev@...il.com>
To:	"Michael Buesch" <mb@...sch.de>
Cc:	"Larry Finger" <Larry.Finger@...inger.net>,
	"Stefano Brivio" <stefano.brivio@...imi.it>,
	"Jeff Garzik" <jgarzik@...ox.com>, "Greg KH" <greg@...ah.com>,
	"Pekka Enberg" <penberg@...helsinki.fi>,
	"Ingo Molnar" <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.

On Sat, Feb 23, 2008 at 7:20 PM, Michael Buesch <mb@...sch.de> wrote:
> On Saturday 23 February 2008 14:17:55 Alexey Zaytsev wrote:
>  > diff --git a/drivers/net/wireless/bcm43xx/Kconfig b/drivers/net/wireless/bcm43xx/Kconfig
>  > index 0159701..afb8f43 100644
>  > --- a/drivers/net/wireless/bcm43xx/Kconfig
>  > +++ b/drivers/net/wireless/bcm43xx/Kconfig
>  > @@ -1,6 +1,6 @@
>  >  config BCM43XX
>  >       tristate "Broadcom BCM43xx wireless support (DEPRECATED)"
>  > -     depends on PCI && IEEE80211 && IEEE80211_SOFTMAC && WLAN_80211 && EXPERIMENTAL
>  > +     depends on PCI && IEEE80211 && IEEE80211_SOFTMAC && WLAN_80211 && (!SSB_B43_PCI_BRIDGE || SSB != y) && EXPERIMENTAL
>
>  so if SSB is m it will break module auto-loading, right?
>

Right.
If ssb == m, you can at least unload the ssb module manually, or
specify the right
module to load. In the first patch I sent to you, it was
"!SSB_B43_PCI_BRIDGE" instead of
"(!SSB_B43_PCI_BRIDGE || SSB != y)", but I thought that there is no reason to
completely hide the bcm43xx option if ssb is compiled as module.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/