linux-kernel - Re: [patch 33/38] SCSI: gdth: scan for scsi devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ec7f7ee70802221902i1d4877afkad86bca0e2a9b479@mail.gmail.com>
Date:	Sat, 23 Feb 2008 05:02:40 +0200
From:	"Boaz Harrosh" <bharrosh@...asas.com>
To:	"Greg KH" <gregkh@...e.de>,
	"James Bottomley" <James.Bottomley@...senpartnership.com>
Cc:	linux-kernel@...r.kernel.org, stable@...nel.org, jejb@...nel.org,
	"Justin Forbes" <jmforbes@...uxtx.org>,
	"Zwane Mwaikambo" <zwane@....linux.org.uk>,
	"Theodore Ts'o" <tytso@....edu>,
	"Randy Dunlap" <rdunlap@...otime.net>,
	"Dave Jones" <davej@...hat.com>,
	"Chuck Wolber" <chuckw@...ntumlinux.com>,
	"Chris Wedgwood" <reviews@...cw.f00f.org>,
	"Michael Krufky" <mkrufky@...uxtv.org>,
	"Chuck Ebbert" <cebbert@...hat.com>,
	"Domenico Andreoli" <cavokz@...il.com>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk
Subject: Re: [patch 33/38] SCSI: gdth: scan for scsi devices

On Sat, Feb 23, 2008 at 2:31 AM, Greg KH <gregkh@...e.de> wrote:
>
>  2.6.24-stable review patch.  If anyone has any objections, please let us
>  know.
>
>  ------------------
>  From: Boaz Harrosh <bharrosh@...asas.com>
>
>  commit: 61c92814dc324b541391757062ff02fbf3b08086
>
>  The patch: "gdth: switch to modern scsi host registration"
>
>  missed one simple fact when moving a way from scsi_module.c.
>  That is to call scsi_scan_host() on the probed host.
>  With this the gdth driver from 2.6.24 is again able to
>  see drives and boot.
>
>  Signed-off-by: Boaz Harrosh <bharrosh@...asas.com>
>  Tested-by: Joerg Dorchain <joerg@...chain.net>
>  Tested-by: Stefan Priebe <s.priebe@...ied-internet.ag>
>  Tested-by: Jon Chelton <jchelton@...global.com>
>  Signed-off-by: James Bottomley <James.Bottomley@...senPartnership.com>
>  Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
>
>  ---
>   drivers/scsi/gdth.c |    9 +++++++++
>   1 file changed, 9 insertions(+)
>
>  --- a/drivers/scsi/gdth.c
>  +++ b/drivers/scsi/gdth.c
>  @@ -4838,6 +4838,9 @@ static int __init gdth_isa_probe_one(ulo
>         if (error)
>                 goto out_free_coal_stat;
>         list_add_tail(&ha->list, &gdth_instances);
>  +
>  +       scsi_scan_host(shp);
>  +
>         return 0;
>
>   out_free_coal_stat:
>  @@ -4965,6 +4968,9 @@ static int __init gdth_eisa_probe_one(us
>         if (error)
>                 goto out_free_coal_stat;
>         list_add_tail(&ha->list, &gdth_instances);
>  +
>  +       scsi_scan_host(shp);
>  +
>         return 0;
>
>   out_free_ccb_phys:
>  @@ -5102,6 +5108,9 @@ static int __init gdth_pci_probe_one(gdt
>         if (error)
>                 goto out_free_coal_stat;
>         list_add_tail(&ha->list, &gdth_instances);
>  +
>  +       scsi_scan_host(shp);
>  +
>         return 0;
>
>   out_free_coal_stat:
>
>  --

Greg, James Hi

This patch is not enough, and will not return a gdth system to working
order. With this patch disks
will show up again, only to crash later. All the 5 patches I sent are
needed, to return to a working
state. James please apply to mainline, so they can be accepted into stable.
of the 5 only 2 I have seen in mainline. 3 are missing.
(if they were submitted, I might have missed them, as I'm traveling, then sorry)

Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/