linux-kernel - Re: bcm43xx regression in 2.6.24 (with patch)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802241816.01784.mb@bu3sch.de>
Date:	Sun, 24 Feb 2008 18:16:01 +0100
From:	Michael Buesch <mb@...sch.de>
To:	"Alexey Zaytsev" <alexey.zaytsev@...il.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Pekka Enberg" <penberg@...helsinki.fi>,
	"Alexey Zaytsev" <zaytsev.a@...tei.ru>, "Greg KH" <greg@...ah.com>,
	linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>
Subject: Re: bcm43xx regression in 2.6.24 (with patch)

On Sunday 24 February 2008, Alexey Zaytsev wrote:
> On Sun, Feb 24, 2008 at 5:29 PM, Michael Buesch <mb@...sch.de> wrote:
> > On Saturday 23 February 2008 12:32:50 Alexey Zaytsev wrote:
> >  > The problem is not with enabling both b43 and bcm43xx (will, whis won't work
> >  > anyway, and there is no chance fixing it). The problem is with enabling the
> >  > bcm43xx wifi driver and the b44 Ethernet driver. The ethernet driver then
> >  > wrongly autosolects some config options that prevent the bcm43xx
> >  > driver from loading, so I'm left with either no wifi or no ethenet.
> >
> >  Ok, so I just tested this on a machine and it is _not_ true.
> >  It works just fine to run b44/ssb with bcm43xx in parallel.
> >
> >  Can you please stop fooling me and spreading this FUD?
> >
> 
> The ony way I see this was possible, you manually changed the
> module loading order, so that the b43xx module was loaded prior
> to the ssb and b44 modules. Right?

Right. So "so I'm left with either no wifi or no ethenet" being wrong.

> Looks like this, kind of, ruins my statement that is is impossible to get
> working wifi in 2.6.24. Sorry, it was not intensinal. ;)

Ok, I see.

> But there still are lots of valid combinations where the b43xx driver
> silently won't work. E.g. when either the ssb or the b44 modules are
> loaded prior to it, or when either of them are built statically (building
> the b43xx driver staticaly won't help here). And my patch fixes them.

With your patch you can still artificially create situations that
something doesn't work.
My point being: It works just fine without the patch.
And as I'm not really sure about the implications of the patch, I
won't ack this. But it seems Larry acked it. So that's also fine, if
he takes over responsibility for that change then. So the next
"You broke my kernel!!11" round can go to his mail address and I won't
be bothered by this anymore. ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/