linux-kernel - Re: [PATCH] Add rdc321x defconfig file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080225115448.GB16376@elte.hu>
Date:	Mon, 25 Feb 2008 12:54:48 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Florian Fainelli <florian.fainelli@...ecomint.eu>,
	linux-kernel@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] Add rdc321x defconfig file


* Adrian Bunk <bunk@...nel.org> wrote:

> On Mon, Feb 25, 2008 at 12:27:34PM +0100, Florian Fainelli wrote:
> > Le lundi 25 février 2008, Adrian Bunk a écrit :
> > > Booting it might fine, but CLOCK_TICK_RATE will be wrong...
> > 
> > PIT_TICK_RATE is overriden specificaly for R321x in 
> > include/asm-x86/timex.h, just like for AMD Elan.
> 
> Not when you try CONFIG_X86_GENERICARCH=y as Ingo suggested.

good point.

The clean solution would be to make PIT_TICK_RATE/CLOCK_TICK_RATE a 
variable that defaults to 1193182 on x86, and which an early quirk would 
set to 1189200 on AMD Elan and to 1041667 on RDC321X.

likewise, other subarch details should be turned into specific drivers 
or specific quirks as well.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/