linux-kernel - Re: [RFC] Genirq and CPU isolation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Feb 2008 10:34:56 -0800
From:	Max Krasnyanskiy <maxk@...lcomm.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [RFC] Genirq and CPU isolation

Randy Dunlap wrote:
> On Fri, 22 Feb 2008 22:19:18 -0800 Max Krasnyansky wrote:
> 
> Hi Max,
> 
>> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
>> index 438a014..e74db94 100644
>> --- a/kernel/irq/manage.c
>> +++ b/kernel/irq/manage.c
>> @@ -488,6 +491,26 @@ void free_irq(unsigned int irq, void *dev_id)
>>  }
>>  EXPORT_SYMBOL(free_irq);
>>  
>> +#ifndef CONFIG_AUTO_IRQ_AFFINITY
>> +/**
>> + * Generic version of the affinity autoselector.
>> + * Called under desc->lock from setup_irq().
>> + * btw Should we rename this to select_irq_affinity() ?
>> + */
> 
> Please don't begin comment blocks with "/**" unless they are in
> kernel-doc format.  (See Documentation/kernel-doc-nano-HOWTO.txt
> for details of it.)
My bad. Cut & pasted another function and forgot to nuke one asterisk.

Thanx for the review Randy.
Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/