linux-kernel - Re: Tabs, spaces, indent and 80 character lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47C335D9.3010803@student.ltu.se>
Date:	Mon, 25 Feb 2008 22:40:41 +0100
From:	Richard Knutsson <ricknu-0@...dent.ltu.se>
To:	Benny Halevy <bhalevy@...asas.com>
CC:	Krzysztof Halasa <khc@...waw.pl>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: Tabs, spaces, indent and 80 character lines

Benny Halevy wrote:
> On Feb. 24, 2008, 7:40 -0800, Richard Knutsson <ricknu-0@...dent.ltu.se> wrote:
>   
>> Krzysztof Halasa wrote:
>>     
>>> Richard Knutsson <ricknu-0@...dent.ltu.se> writes:
>>>
>>>   
>>>       
>>>> Why hinder a developer who prefer
>>>> 2, 4, 6 or any other != 8 width?
>>>>     
>>>>         
>>> I guess we could use tabs only at the line start, for indentation
>>> only. Rather hard to implement, most text editors can't do that yet.
>>>   
>>>       
>> You mean for split lines? Hopefully there won't be that many, so there 
>> is just to delete the tabs it added and replace it with spaces.
>>     
>
> IMO, tabs SHOULD be used for syntactic indentation and spaces for
> decoration purpose only.  I.e. a line should start with a number of tabs
> equal to its nesting level and after that only spaces should be used.
> for example, the following code
>
> for (i = 0; i < n; i++) printk("a very long format string", some, parameters);
>
> should be formatted like this:
>
> <tabs...>for (i = 0; i < n; i++)
> <tabs...><tab>printk("a very long format string",
> <tabs...><tab>       some, parameters);
>
> this will show exactly right regardless of your editor's tab expansion setting
> as long as you use fixed-width fonts - where the screen width of the space character
> is equal to all other characters.  Once you start using tabs instead of spaces
> to push text right so it appears exactly below some other text on the line above
> you make a dependency on *your* editor's tab expansion policy and that's not very
> considerate for folks who prefer a different one.
>   
Don't know what to say more then: Yup! :)

But the CodeStyle-document and checkpatch.pl does not agree with that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/