| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Feb 2008 23:21:47 +0100 From: Pavel Machek <pavel@....cz> To: Jeff Garzik <jeff@...zik.org> Cc: "Rafael J. Wysocki" <rjw@...k.pl>, "Michael S. Tsirkin" <m.s.tsirkin@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org>, Alexey Starikovskiy <astarikovskiy@...e.de>, Len Brown <len.brown@...el.com>, linux-acpi@...r.kernel.org Subject: Re: broken suspend in .2.6.25-rc3 on T61p (was Re: new regression in 2.6.25-rc3: no keyboard/lid acpi events on thinkpad T61p) On Mon 2008-02-25 16:32:38, Jeff Garzik wrote: > Pavel Machek wrote: >>> commit 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 >>> Author: Pavel Machek <pavel@....cz> >>> Date: Thu Feb 21 13:56:55 2008 +0100 >>> >>> power_state: get rid of write-only variable in SATA >> >> This is pretty unlikely to be it. Can you double check that this patch >> really breaks something? > > Quote... > > After reverting 559bbe6cbd0d8c68d40076a5f7dc98e3bf5864b2 > on top of 2.6.25-rc3 the kernel again resumes from suspend to > ram. > > Seems pretty clear to me. Yep, that patch was crappy. I developed it on machine with SCSI powersave patches applied, and did not realize this code changed. Sorry. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists