linux-kernel - Re: [PATCH 1/2] [W1] ds1wm: should check for IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080225222617.GA11899@2ka.mipt.ru>
Date:	Tue, 26 Feb 2008 01:26:17 +0300
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Matt Reimer <mreimer@...p.net>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/2] [W1] ds1wm: should check for IS_ERR(clk) instead of NULL

Hi Anton.

On Tue, Feb 26, 2008 at 12:24:26AM +0300, Anton Vorontsov (cbouatmailru@...il.com) wrote:
> On the error condition clk_get() returns ERR_PTR(..), so checking
> for NULL doesn't work. ds1wm module causes a kernel oops when ds1wm
> clock isn't registered.
> 
> This patch converts NULL check to IS_ERR(), plus uses PTR_ERR()
> for the return code.
> 
> Signed-off-by: Anton Vorontsov <cbouatmailru@...il.com>

Both patches look good, thanks Anton.

Andrew, please merge them and add my ack if needed.
Thank you.

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/