linux-kernel - Re: [(RT RFC) PATCH v2 6/9] add a loop counter based timeout mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1203979169.16711.101.camel@sven.thebigcorporation.com>
Date:	Mon, 25 Feb 2008 14:39:29 -0800
From:	Sven-Thorsten Dietrich <sdietrich@...ell.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Gregory Haskins <ghaskins@...ell.com>, mingo@...e.hu,
	a.p.zijlstra@...llo.nl, tglx@...utronix.de, rostedt@...dmis.org,
	linux-rt-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	bill.huey@...il.com, kevin@...man.org, cminyard@...sta.com,
	dsingleton@...sta.com, dwalker@...sta.com, npiggin@...e.de,
	dsaxena@...xity.net, ak@...e.de, acme@...hat.com, gregkh@...e.de,
	pmorreale@...ell.com, mkohari@...ell.com
Subject: Re: [(RT RFC) PATCH v2 6/9] add a loop counter based timeout
	mechanism


On Mon, 2008-02-25 at 23:06 +0100, Pavel Machek wrote:
> On Mon 2008-02-25 11:01:08, Gregory Haskins wrote:
> > From: Sven Dietrich <sdietrich@...ell.com>
> 
> Why is this good idea?
> 

The timeout is useful to eliminate excessive CPU utilization when
waiting for long-held critical sections. 

The patch header should state this :) Will fix.

> > Signed-off-by: Sven Dietrich <sdietrich@...ell.com>
> > ---
> 
> >  
> > +config RTLOCK_DELAY
> > +	int "Default delay (in loops) for adaptive rtlocks"
> > +	range 0 1000000000
> > +	depends on ADAPTIVE_RTLOCK
> > +	default "10000"
> > +        help
> > +         This allows you to specify the maximum attempts a task will spin
> > +	 attempting to acquire an rtlock before sleeping.  The value is
> > +	 tunable at runtime via a sysctl.  A setting of 0 (zero) disables
> > +	 the adaptive algorithm entirely.
> > +
> 
> I believe you have _way_ too many config variables. If this can be set
> at runtime, does it need a config option, too?
> 

Absolutely. The sysctl was added after-the-fact, so this is a relic, we
will remove the config option, and define the default timeout in the
appropriate header.

Sven

> 									Pavel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/