lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 25 Feb 2008 14:49:22 -0800 From: Andrew Morton <akpm@...ux-foundation.org> To: Pekka Paalanen <pq@....fi> Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>, Christoph Hellwig <hch@...radead.org>, Arjan van de Ven <arjan@...radead.org>, Pavel Roskin <proski@....org>, Steven Rostedt <rostedt@...dmis.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Andy Whitcroft <apw@...dowen.org> Subject: Re: [RFC] mmiotrace full patch, preview 1 On Sun, 24 Feb 2008 19:03:23 +0200 Pekka Paalanen <pq@....fi> wrote: > arch/x86/Kconfig.debug | 33 +++ > arch/x86/mm/Makefile | 5 + > arch/x86/mm/fault.c | 13 + > arch/x86/mm/kmmio.c | 541 +++++++++++++++++++++++++++++++++++++++++++ > arch/x86/mm/mmio-mod.c | 541 +++++++++++++++++++++++++++++++++++++++++++ > arch/x86/mm/pageattr.c | 1 + > arch/x86/mm/pf_in.c | 489 ++++++++++++++++++++++++++++++++++++++ > arch/x86/mm/pf_in.h | 39 +++ > arch/x86/mm/testmmiotrace.c | 76 ++++++ > include/linux/mmiotrace.h | 104 +++++++++ Please feed the diff through scritps/checkpatch.pl and consider addressing the things which it finds. > +static DECLARE_MUTEX(kmmio_init_mutex); That's not a mutex. > + down(&kmmio_init_mutex); It's a semaphore. Please do convert it to a mutex. Andy, I'd say that addition of new semaphores is worth a warning - they're rarely legitimate. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists