linux-kernel - Re: [PATCH] x86: add the debugfs interface for the sysprof tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080226085541.GE9857@elte.hu>
Date:	Tue, 26 Feb 2008 09:55:41 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Nicholas Miell <nmiell@...cast.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arjan van de Ven <arjan@...radead.org>,
	linux-kernel@...r.kernel.org, sandmann@...hat.com, tglx@...x.de,
	hpa@...or.com, levon@...ementarian.org
Subject: Re: [PATCH] x86: add the debugfs interface for the sysprof tool


* Pekka Enberg <penberg@...helsinki.fi> wrote:

> Hi,
> 
> On Tue, Feb 26, 2008 at 8:27 AM, Pekka Enberg <penberg@...helsinki.fi> wrote:
> > >  You could try passing the --callgraph option to opcontrol.
> >
> >  Hmm, perhaps I am missing something but I don't think that does what
> >  sysprof does. At least I can't find where in the oprofile kernel code
> >  does it save the full stack trace for user-space. John?
> 
> Ok, so as pointed out by Nicholas/Andrew, oprofile does indeed do 
> exactly what sysprof does (see 
> arch/x86/oprofile/backtrace.c::backtrace_address, for example). So, 
> Soeren, any other reason we can't use the oprofile kernel module for 
> sysprof?

as i pointed it out earlier in the thread, the oprofile implementation 
seems buggy because when an event comes from NMI context 
__copy_from_user_inatomic() can fault and re-enable NMIs - causing 
possible stack recursion/corruption. Does not look like an easy fix.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/