linux-kernel - Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080226124506.681dfac9@core>
Date:	Tue, 26 Feb 2008 12:45:06 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	torvalds@...l.org, "Cai, Crane" <Crane.Cai@....com>
Subject: Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk

> I agree.  I [obviously] missed this when I ack'd, mainly ack'ing the 
> overall change.
> 
> BIOS certainly may modify that PCI config register, but that's before 
> the kernel boots.  So, using pdev->class is fine.

I don't think the resume quirk is needed either as the core PCI
save/restore code rewrites the PCI registers so should be rewriting the
class back on resume as well.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/