linux-kernel - Re: [PATCH] x86_64: remove wrong setting about CONSTANT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86802c440802260929tc8f7a19i73552b0e5928e570@mail.gmail.com>
Date:	Tue, 26 Feb 2008 09:29:25 -0800
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Thomas Gleixner" <tglx@...utronix.de>
Subject: Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu

On Mon, Feb 25, 2008 at 11:33 PM, H. Peter Anvin <hpa@...or.com> wrote:
> Yinghai Lu wrote:
>  >>  which is the same. set_cpu_cap() is indeed the cleaner form to do this
>  >>  so your patch is correct as a cleanup.
>  > set_cpu_cap is right
>  > ==
>  > set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); ===> is wrong
>  > should be
>  > set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability);
>  >
>  > x86_capability is a array ...
>  >
>
>  For an array, the & is optional and has no effect.

good to know.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/