linux-kernel - Re: [Linux-fbdev-devel] [PATCH] fbcon: replace mono

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1204062602.5582.38.camel@brick>
Date:	Tue, 26 Feb 2008 13:50:02 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Linux Frame Buffer Device Development 
	<linux-fbdev-devel@...ts.sourceforge.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Antonino Daplas <adaplas@...il.com>
Subject: Re: [Linux-fbdev-devel] [PATCH] fbcon: replace mono_col macro with
	static inline

On Tue, 2008-02-26 at 22:36 +0100, Geert Uytterhoeven wrote:
> On Tue, 26 Feb 2008, Harvey Harrison wrote:
> > On Tue, 2008-02-26 at 09:18 +0100, Geert Uytterhoeven wrote:
> > > On Mon, 25 Feb 2008, Harvey Harrison wrote:
> > > > +static inline int mono_col(struct fb_info *info)
> > >                               ^^^^^^^^^^^^^^^^^^^^
> > > const struct fb_info *info?
> > 
> > I suppose, but seeing as it's an inline, does it really matter?
> 
> Sure, if one day a new routine calls mono_col() passing a const struct fb_info
> pointer, it won't compile.

Fair enough, want an updated patch, or will Andrew just make the small
addition?

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/