linux-kernel - Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47C49BDD.50205@garzik.org>
Date:	Tue, 26 Feb 2008 18:08:13 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Stephen Hemminger <shemminger@...tta.com>
CC:	Pekka J Enberg <penberg@...helsinki.fi>, romieu@...zoreil.com,
	sorbica@...lus.com.tw, jesse@...lus.com.tw,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option

Stephen Hemminger wrote:
>> From: Pekka Enberg <penberg@...helsinki.fi>
>>
>> Convert the internal JUMBO_FRAME #ifdef to CONFIG_IP1000_JUMBO_FRAME proper and
>> fix compilation errors.
>>
>> Cc: Francois Romieu <romieu@...zoreil.com>
>> Cc: Sorbica Shieh <sorbica@...lus.com.tw>
>> Cc: Jesse Huang <jesse@...lus.com.tw>
>> Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> 
> Please don't do this as a config option. Config options seem like a good idea
> to developers but are difficult for distributions.  Either support jumbo
> frames by default or not at all.

Agreed, but to be more specific...    always compile in jumbo frame 
support.  You don't have to enable it at runtime by default, though.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/