linux-kernel - Re: [PATCH] x86 vdso: fix build locale dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080227204513.GB1510@elte.hu>
Date:	Wed, 27 Feb 2008 21:45:13 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Roland McGrath <roland@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Priit Laes <plaes@...es.org>
Subject: Re: [PATCH] x86 vdso: fix build locale dependency


* Sam Ravnborg <sam@...nborg.org> wrote:

> On Wed, Feb 27, 2008 at 11:42:15AM -0800, Roland McGrath wrote:
> > 
> > Priit Laes discovered that the sed command processing nm output was
> > sensitive to locale settings.  This was addressed in commit
> > 03994f01e8b72b3d01fd3d09d1cc7c9f421a727c by using [:alnum:] in place of
> > [a-zA-Z0-9].  But that too is locale-dependent and may not always match
> > the identifiers it needs to.  The better fix is just to run sed et al
> > with a fixed locale setting in all builds.
> 
> Priit's original patch used the LC_ALL trick. It is me to blame that 
> it was replaced with [:alnum:] :-(

ok. I've queued up Roland's re-fix. We'll eventually converge to 
something everyone is happy with ;-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/