linux-kernel - Re: [PATCH 8/9] fs/ocfs2/aops.c: Correct use of ! and &

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080227212645.GP27865@ca-server1.us.oracle.com>
Date:	Wed, 27 Feb 2008 13:26:45 -0800
From:	Mark Fasheh <mark.fasheh@...cle.com>
To:	Julia Lawall <julia@...u.dk>
Cc:	kurt.hackel@...cle.com, ocfs2-devel@....oracle.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 8/9] fs/ocfs2/aops.c: Correct use of ! and &

On Tue, Feb 26, 2008 at 09:45:56PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> In commit e6bafba5b4765a5a252f1b8d31cbf6d2459da337, a bug was fixed that
> involved converting !x & y to !(x & y).  The code below shows the same
> pattern, and thus should perhaps be fixed in the same way.
> 
> This is not tested and clearly changes the semantics, so it is only
> something to consider.

That looks fine - it's in Ocfs2.git now, thanks.
	--Mark

--
Mark Fasheh
Principal Software Developer, Oracle
mark.fasheh@...cle.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/