| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200802271642.57556.paul.moore@hp.com> Date: Wed, 27 Feb 2008 16:42:57 -0500 From: Paul Moore <paul.moore@...com> To: Adrian Bunk <bunk@...nel.org> Cc: sds@...ho.nsa.gov, jmorris@...ei.org, eparis@...isplace.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [2.6 patch] selinux/netlabel.c should #include "netlabel.h" On Wednesday 27 February 2008 4:20:42 pm Adrian Bunk wrote: > Every file should include the headers containing the externs for its > global code. > > Signed-off-by: Adrian Bunk <bunk@...nel.org> It doesn't _need_ the file in the strictest sense, the header file is just there for the core SELinux code to call into the NetLabel/SELinux glue code (what is in security/selinux/netlabel.c). However, if this is to conform better to kernel coding policy (I assume that is the case here?) then that is fine with me. Acked-by: Paul Moore <paul.moore@...com> > --- > 1f65757bac3e82514b447822ab30ee10d33a59a2 foobar > diff --git a/security/selinux/netlabel.c > b/security/selinux/netlabel.c index 0fa2be4..6d22d76 100644 > --- a/security/selinux/netlabel.c > +++ b/security/selinux/netlabel.c > @@ -34,6 +34,7 @@ > > #include "objsec.h" > #include "security.h" > +#include "netlabel.h" > > /** > * selinux_netlbl_sidlookup_cached - Cache a SID lookup -- paul moore linux security @ hp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists