| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Feb 2008 17:08:04 -0500 From: Paul Moore <paul.moore@...com> To: Adrian Bunk <bunk@...nel.org> Cc: sds@...ho.nsa.gov, jmorris@...ei.org, eparis@...isplace.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [2.6 patch] selinux/netlabel.c should #include "netlabel.h" On Wednesday 27 February 2008 4:55:43 pm Adrian Bunk wrote: > On Wed, Feb 27, 2008 at 04:42:57PM -0500, Paul Moore wrote: > > On Wednesday 27 February 2008 4:20:42 pm Adrian Bunk wrote: > > > Every file should include the headers containing the externs for > > > its global code. > > > > > > Signed-off-by: Adrian Bunk <bunk@...nel.org> > > > > It doesn't _need_ the file in the strictest sense, the header file > > is just there for the core SELinux code to call into the > > NetLabel/SELinux glue code (what is in > > security/selinux/netlabel.c). However, if this is to conform > > better to kernel coding policy (I assume that is the case here?) > > then that is fine with me. > > I'm not claiming it needs it. > > But with this #include gcc can check that the prototypes in > netlabel.h match the functions in netlabel.c > > The bugs this catches are rare, but when you have such a bug it can > be nasty to debug. Good point, hadn't thought of that - thanks. > > Acked-by: Paul Moore <paul.moore@...com> -- paul moore linux security @ hp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists