linux-kernel - Re: Kconfig configuration restore bug [Was: x86: vSMP selection in config]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0802270353480.2723@scrub.home>
Date:	Wed, 27 Feb 2008 03:59:45 +0100 (CET)
From:	Roman Zippel <zippel@...ux-m68k.org>
To:	Sam Ravnborg <sam@...nborg.org>
cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	kiran@...lemp.com, shai@...lemp.com,
	Glauber Costa <gcosta@...hat.com>,
	linux-kbuild <linux-kbuild@...r.kernel.org>,
	Yinghai Lu <Yinghai.Lu@....COM>
Subject: Re: Kconfig configuration restore bug [Was: x86: vSMP selection in
 config]

Hi,

On Tue, 26 Feb 2008, Sam Ravnborg wrote:

> choice
> 	prompt "Subarchitecture Type"
> 
> config X86_PC
> 	bool "PC-compatible"
> 
> config X86_VOYAGER
> 	bool "Voyager (NCR)"
> 
> config X86_VSMP
> 	bool "Support for ScaleMP vSMP"
> 	depends on PCI
> 
> endchoice
> 
> config PCI
> 	bool "PCI support" if !X86_VISWS
> 	depends on !X86_VOYAGER
> 	default y

The basic problem is that this is a recursive dependency - PCI depends on 
the choice and the choice depends on PCI. IMO X86_VSMP cannot depend on 
PCI.
I'm looking into why this hasn't been picked up by the dependency check...

bye, Roman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/