linux-kernel - Re: [PATCH] CodingStyle: multiple updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0802280116260.5388@fbirervta.pbzchgretzou.qr>
Date:	Thu, 28 Feb 2008 01:18:23 +0100 (CET)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	SL Baur <steve@...acs.org>
cc:	Richard Knutsson <ricknu-0@...dent.ltu.se>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Krzysztof Halasa <khc@...waw.pl>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	bhalevy.lists@...il.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] CodingStyle: multiple updates


On Feb 27 2008 16:11, SL Baur wrote:
>On 2/27/08, Richard Knutsson <ricknu-0@...dent.ltu.se> wrote:
>
>>  Actually, I see this as an quite simple question: is tab _the
>>  indention-marker_? If not, then why the refusal of spaces indents (or mix)?
>
>Because mixing spaces and tabs is often ugly.  8 spaces and a
>single tab often do not have the same width when you're viewing
>the text in a variable width font.

By the way, neither tab nor bunch-a'-spaces makes alignment look good.
Try:

	/* fails when !monospace || tab != 8 */
	fprintf(fp, KERN_WARNING
		"Opening quotes should be right after (");

	/* fails if !monospace */
	fprintf(fp, KERN_WARNING
	        "Opening quotes should be right after (");

hm... :-/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/