linux-kernel - Re: [PATCH 1/2] firewire: endianess fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47C673B0.2070705@s5r6.in-berlin.de>
Date:	Thu, 28 Feb 2008 09:41:20 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	benh@...nel.crashing.org
CC:	Kristian Hoegsberg <krh@...planet.net>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	sparclinux@...r.kernel.org, linux1394-devel@...ts.sourceforge.net,
	Sam Ravnborg <sam@...nborg.org>,
	Harvey Harrison <harvey.harrison@...il.com>
Subject: Re: [PATCH 1/2] firewire: endianess fix

Benjamin Herrenschmidt wrote:
> Do we have the workaround for the old Apple UniNorth in the new FW OHCI
> driver (for selfID swapping iirc ?)

According to ohci1394.c, it selfIDs and headers of incoming packets are 
not byte-swapped by the old Apple Uninorth FireWire part.  And no, 
firewire-ohci doesn't have the workaround yet.

It should be trivial to copy'n'paste ohci1394's workaround into fw-ohci, 
but it would be good if someone could test before and after.

BTW, since that code is touched everytime a packet is received, we 
should enclose such a workaround in #ifdef CONFIG_PPC_PMAC && 
CONFIG_PPC32, shouldn't we?  (As a second step after adding the workaround.)
-- 
Stefan Richter
-=====-==--- --=- ===--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/