| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200802281142.27755.lerichi@gmx.net> Date: Thu, 28 Feb 2008 11:42:27 +0100 From: Richard Hacker <lerichi@....net> To: Sam Ravnborg <sam@...nborg.org> Cc: kai@...maschewski.name, linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org Subject: Re: [PATCH 001/002] scripts/mod/modpost.c: New option -E to load extra symbols Hello Sam, > At first quick look it looked good and I have only two comments: > 1) The variable should be named KBUILD_* to fit the general namespace used I wanted to use the namespace EXTRA_* to continue the line of EXTRA_CFLAGS, etc. that were used when building modules. Is that OK? The other names sound odd to me: KBUILD_SYMBOLS or KBUILD_EXTRA_SYMBOLS. If you really do not like EXTRA_SYMBOLS, which one do you propose? > 2) The new possibility should be documented in > Documentation/kbuild/modules.txt [PATCH 002/002] in this revised series updated scripts/Makefile.modpost to use this new feature of modpost, and documented the change as well. Please take a look at it: http://lkml.org/lkml/2008/2/28/72 > PS. Please also cc: linux-kbuild@...r.kernel.org if you submit again. Did it. (For new readers in linux-kbuild: The original patchset can be found at: http://lkml.org/lkml/2008/2/28/71 for [PATCH 001/002] http://lkml.org/lkml/2008/2/28/72 for [PATCH 002/002] ) - Richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists