linux-kernel - Re: [PATCH 2/6] Add chip driver for WM9705 touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080228114633.GA20092@rakim.wolfsonmicro.main>
Date:	Thu, 28 Feb 2008 11:46:33 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Dmitry Torokhov <dtor@...l.ru>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Liam Girdwood <liam.girdwood@...fsonmicro.com>,
	Graeme Gregory <gg@...nsource.wolfsonmicro.com>,
	Dmitry Baryshkov <dbaryshkov@...il.com>,
	Rodolfo Giometti <giometti@...eenne.com>,
	Russell King <rmk@....linux.org.uk>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Pete MacKay <linux01@...hitechnical.net>,
	Ian Molton <spyro@....com>, Vince Sanders <vince@...likki.org>,
	Andrew Zabolotny <zap@...elink.ru>
Subject: Re: [PATCH 2/6] Add chip driver for WM9705 touchscreen

On Wed, Feb 27, 2008 at 11:09:32PM -0800, Andrew Morton wrote:
> On Tue, 26 Feb 2008 13:40:14 +0000 Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> > + *
> > + * Adjust this value if you are having problems with pen detect not
> > + * detecting any down events.
> > + */
> > +static int pdd = 8;
> > +module_param(pdd, int, 0);
> > +MODULE_PARM_DESC(pdd, "Set pen detect comparator threshold");

> I guess that's all the documentation we get ;) It won't kill us - we've done
> worse..

> It would be rather nice if the kerneldoc system could extract the above
> comments and put them in a module-parameters-documentation section, but I
> don't think it can do that.

What would be really nice for this application would be a way to pass
platform data to devices enumerated by non-platform buses - most of the
time these parameters are determined by the board the system is on.  In
that case we'd be able to provide kerneldoc for the struct used to pass
in platform data.

> > +	if (timeout <= 0) {

> timeout cannot be negative here.

Fixed, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/