linux-kernel - x86: potential ioremap() issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <47C6BE37.76E4.0078.0@novell.com>
Date:	Thu, 28 Feb 2008 12:59:19 +0000
From:	"Jan Beulich" <jbeulich@...ell.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	<linux-kernel@...r.kernel.org>
Subject: x86: potential ioremap() issues

Ingo,

with the new ioremap() implementation I see a couple of (potential)
issues:
- When ioremap_page_range() fails, remove_vm_area() is used rather
  than vunmap() - I think this will cause a 'struct vm_struct' leak.
- While ioremap() continues to happily map RAM pages (with a bogus
  [see below] WARN_ON_ONCE()), cacheability of the memory is not
  being restored in iounmap().
- The check for RAM pages (except for the WARN_ON_ONCE())
  continues to be applied only to lowmem pages.
- The WARN_ON_ONCE() itself is applied to the pfn after the
  preceding loop finished, i.e. to a pfn that doesn't actually participate
  in the operation. Shouldn't it be moved inside the loop?

Thanks for any clarification,
Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/