linux-kernel - Re: [PATCH] cpuset: fix return value of cpuset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47C60910.7000102@cn.fujitsu.com>
Date:	Thu, 28 Feb 2008 09:06:24 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Paul Menage <menage@...gle.com>
CC:	Paul Jackson <pj@....com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpuset: fix return value of cpuset_populate()

Paul Menage wrote:
> On Tue, Feb 26, 2008 at 11:41 PM, Paul Jackson <pj@....com> wrote:
>>  - no need to check err == 0
>>  - the last return value of cgroup_add_file() is ignored
>>
>>  Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> 
> Looks fine from a cleanliness PoV, although since we don't actually do
> anything with an error result from subsys->populate() (a behaviour
> that I sort of inherited from cpusets ...) it won't make a whole lot
> of difference to the code.
> 
> A better change would be to make cpuset_populate() use cgroup_add_files().
> 

Yes, I'm considering this, and I will verify if this will save some bytes
in the object file.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/